HUE-1006 [beeswax] Support download of large files

Review Request #3198 — Created June 19, 2013 and submitted

romain
old-hue-rw
HUE-1006
hue
abec, enricoberti, kevin.wang
commit 6f0688ba1f7088eadd6d20a3fe77a129a2834834
Author: Romain Rigaux <romain@cloudera.com>
Date:   Wed Jun 19 00:23:18 2013 -0700

    HUE-1006 [beeswax] Support download of large files
    
    Tell to save into HDFS in did you know.

:100644 100644 1a61035... 7d89a65... M	apps/beeswax/src/beeswax/forms.py
:100644 100644 0a2f601... 1537e31... M	apps/beeswax/src/beeswax/templates/watch_results.mako
:100644 100644 fe9623e... 36d3e70... M	apps/beeswax/src/beeswax/tests.py
:100644 100644 4b4c6d8... eba3f34... M	apps/beeswax/src/beeswax/views.py


  • 1
  • 0
  • 0
  • 0
  • 1
Description From Last Updated
Switch order of conditionals? abec abec
abec
  1. Just a thought: Would be interesting to provide a way to select folders that don't exist. Or maybe select the parent directory, then provide a name.
    
    Looks good!
    1. "Would be interesting to provide a way to select folders that don't exist" it is what we do, it forces the user to select a new folder.
      
      I almost removed this restriction too but it overwrites the destination, so not sure if we should remove it and put a warning or just keep it like now.
  2. apps/beeswax/src/beeswax/forms.py (Diff revision 1)
     
     
     
     
     
    Switch order of conditionals?
    1. I don't think fs.exists(weird path) fails, even elif might be cleaner and switching would not change the logic as both are mutually exclusive. But maybe it seems easier to read the other way indeed.
  3. pathChooser => directory selection? Not sure how beeswax does this.
    1. we use pathChooser everywhere as a convention for the js plugin (either for directory or file or both), it is simpler to keep it the same I think
  4. 
      
romain
Review request changed

Status: Closed (submitted)

Loading...