ACCESS-217. Allow URIs to be specified in per DB policy file

Review Request #3292 — Created July 13, 2013 and updated

shreepadma
old-access
trunk
ACCESS-217
access
brock, prasadm
This patch allows URIs to be specified in the per DB policy files under a system property. 
New unit test cases have been added. New integration test has been added. All tests pass locally.
  • 3
  • 0
  • 0
  • 0
  • 3
Description From Last Updated
I think we should have a common public static String for the property name. It's used in more that one ... prasadm prasadm
I changed this. But wouldn't renaming be just a search and replace within the project using eclipse? shreepadma shreepadma
I'm aware that this will not work with external HS2. The hope is the fix will go away when tests ... shreepadma shreepadma
prasadm
  1. LGTM
    The only suggestion is to create a public string for the property name instead of hardcoding at multiple places
  2. I think we should have a common public static String for the property name. It's used in more that one places and needs to be updated as part of project name change.
  3. Nit: Should the message be more like "Can't combine DB and URI scope in a role" ?
  4. Nit: Should it force the HS2 restart ? Will it work with server running in external JVM ? Given that its a short term solution, it should be fine if it only works for internal HS2. Its better to add a comment in the test.
  5. 
      
shreepadma
  1. 
      
  2. I changed this. But wouldn't renaming be just a search and replace within the project using eclipse?
    1. yes, I wasn't suggesting to rename it as part of this patch. That would be handled in revised patch of ACCESS-214.
  3. I'm aware that this will not work with external HS2. The hope is the fix will go away when tests are run with external HS2 e.g., QE cluster. If it still persists, we can address it by passing the system property to external HS2.
  4. 
      
Loading...