HUE-1535 [core] Restructure top bar

Review Request #3596 - Created Sept. 17, 2013 and submitted

Enrico Berti
old-hue-rw
HUE-1535
hue
abec, romain
commit a88a024660e7d15fe46f8ff736bd78ae37aa04f6
Author: Enrico Berti <hello@enricoberti.com>
Date:   Tue Sep 17 08:53:15 2013 +0200

    HUE-1535 [core] Restructure top bar
    
    New take on the top bar

:100644 100644 5ca6f90... a495c7b... M	apps/about/src/about/templates/admin_wizard.mako
:000000 100644 0000000... e8f7413... A	apps/about/src/about/templates/header.mako
:100644 100644 263db9e... a305025... M	apps/beeswax/src/beeswax/templates/choose_delimiter.mako
:100644 100644 30162bb... e401ef9... M	apps/beeswax/src/beeswax/templates/choose_file.mako
:100644 100644 75050fd... 0bf1b75... M	apps/beeswax/src/beeswax/templates/configuration.mako
:100644 100644 1b9c9a1... d3fc659... M	apps/beeswax/src/beeswax/templates/create_database.mako
:100644 100644 d330843... 6bb566f... M	apps/beeswax/src/beeswax/templates/create_table_manually.mako
:100644 100644 8879e1e... 30e2a39... M	apps/beeswax/src/beeswax/templates/define_columns.mako
:100644 100644 bf47c0d... 86e5308... M	apps/beeswax/src/beeswax/templates/execute.mako
:100644 100644 80cbee8... c8a9802... M	apps/beeswax/src/beeswax/templates/explain.mako
:100644 100644 d473b93... c95a347... M	apps/beeswax/src/beeswax/templates/layout.mako
:100644 100644 add3247... 6c6bd33... M	apps/beeswax/src/beeswax/templates/list_designs.mako
:100644 100644 c6f3f6d... eae021b... M	apps/beeswax/src/beeswax/templates/list_history.mako
:100644 100644 4822d56... 863830b... M	apps/beeswax/src/beeswax/templates/list_trashed_designs.mako
:100644 100644 26ceab8... 986e763... M	apps/beeswax/src/beeswax/templates/my_queries.mako
:100644 100644 a5313f4... e1d8ad1... M	apps/beeswax/src/beeswax/templates/parameterization.mako
:100644 100644 7903181... 9652b7d... M	apps/beeswax/src/beeswax/templates/save_results.mako
:100644 100644 17e77fc... 7c8ad62... M	apps/beeswax/src/beeswax/templates/watch_results.mako
:100644 100644 9e321ca... 3470a77... M	apps/beeswax/src/beeswax/templates/watch_wait.mako
:100644 100644 6314d85... 5c19757... M	apps/filebrowser/src/filebrowser/templates/display.mako
:100644 100644 d9955b0... 6a9131d... M	apps/filebrowser/src/filebrowser/templates/edit.mako
:100644 100644 1d8b1c2... 271860d... M	apps/filebrowser/src/filebrowser/templates/fb_components.mako
:100644 100644 d170f71... ef844c9... M	apps/filebrowser/src/filebrowser/templates/listdir.mako
:100644 100644 1638199... 85af008... M	apps/hbase/src/hbase/templates/app.mako
:100644 100644 a2454d0... d17eef4... M	apps/jobbrowser/src/jobbrowser/templates/attempt.mako
:100644 100644 0000b51... 093b1f8... M	apps/jobbrowser/src/jobbrowser/templates/attempt_logs.mako
:100644 100644 7a06fa0... 395bff2... M	apps/jobbrowser/src/jobbrowser/templates/job.mako
:100644 100644 8182362... 78421da... M	apps/jobbrowser/src/jobbrowser/templates/job_attempt_logs.mako
:100644 100644 397c5fc... 1990235... M	apps/jobbrowser/src/jobbrowser/templates/jobbrowser_components.mako
:100644 100644 de6a94f... cd699c5... M	apps/jobbrowser/src/jobbrowser/templates/jobs.mako
:100644 100644 456aa27... 771ba0b... M	apps/jobbrowser/src/jobbrowser/templates/task.mako
:100644 100644 852a40b... 85d29d9... M	apps/jobbrowser/src/jobbrowser/templates/tasks.mako
:100644 100644 8c03d3b... 5d8e80c... M	apps/jobbrowser/src/jobbrowser/templates/tasktracker.mako
:100644 100644 1e16117... d64bdce... M	apps/jobbrowser/src/jobbrowser/templates/tasktrackers.mako
:100644 100644 7241464... e531cd2... M	apps/jobsub/src/jobsub/templates/designs.mako
:100644 100644 0d0e5a1... 45c529d... M	apps/jobsub/static/css/jobsub.css
:100644 100644 72af6cb... 8dabf40... M	apps/metastore/src/metastore/settings.py
:100644 100644 b11b306... fec00b1... M	apps/metastore/src/metastore/templates/components.mako
:100644 100644 e51a719... f1a8e4c... M	apps/metastore/src/metastore/templates/databases.mako
:100644 100644 ae912ec... 0779776... M	apps/metastore/src/metastore/templates/describe_partitions.mako
:100644 100644 45fad7b... 8eef013... M	apps/metastore/src/metastore/templates/describe_table.mako
:100644 100644 47efbe1... 366e8bb... M	apps/metastore/src/metastore/templates/tables.mako
:000000 100644 0000000... cd74ce8... A	apps/metastore/static/art/icon_metastore_24.png
:100644 000000 cd74ce8... 0000000... D	apps/metastore/static/art/table-browser-24-1.png
:100644 100644 ee70853... 8b282d8... M	apps/metastore/static/css/metastore.css
:100644 100644 1565902... b56bf56... M	apps/oozie/src/oozie/templates/dashboard/list_oozie_bundle.mako
:100644 100644 35a7043... 8b4a9f1... M	apps/oozie/src/oozie/templates/dashboard/list_oozie_bundles.mako
:100644 100644 0034aba... f1c84ed... M	apps/oozie/src/oozie/templates/dashboard/list_oozie_coordinator.mako
:100644 100644 414dfd0... 3b2a8aa... M	apps/oozie/src/oozie/templates/dashboard/list_oozie_coordinators.mako
:100644 100644 01fccb4... facc068... M	apps/oozie/src/oozie/templates/dashboard/list_oozie_info.mako
:100644 100644 b58a31d... 6a8079f... M	apps/oozie/src/oozie/templates/dashboard/list_oozie_workflow.mako
:100644 100644 fda505e... d517bec... M	apps/oozie/src/oozie/templates/dashboard/list_oozie_workflow_action.mako
:100644 100644 1185ad2... fc7e9ca... M	apps/oozie/src/oozie/templates/dashboard/list_oozie_workflows.mako
:100644 100644 d91a9ac... 3e6f40f... M	apps/oozie/src/oozie/templates/editor/create_bundle.mako
:100644 100644 843f170... c995662... M	apps/oozie/src/oozie/templates/editor/create_coordinator.mako
:100644 100644 79b17b0... 96496c4... M	apps/oozie/src/oozie/templates/editor/create_workflow.mako
:100644 100644 817c0b6... 609ed00... M	apps/oozie/src/oozie/templates/editor/edit_bundle.mako
:100644 100644 8de9360... 376d7dd... M	apps/oozie/src/oozie/templates/editor/edit_coordinator.mako
:100644 100644 627cc44... c1bd262... M	apps/oozie/src/oozie/templates/editor/edit_workflow.mako
:100644 100644 d4a7e14... 3febeed... M	apps/oozie/src/oozie/templates/editor/import_workflow.mako
:100644 100644 9ec2f63... b358b4d... M	apps/oozie/src/oozie/templates/editor/list_bundles.mako
:100644 100644 1ed157d... 6ca4ab8... M	apps/oozie/src/oozie/templates/editor/list_coordinators.mako
:100644 100644 fa97010... 8568237... M	apps/oozie/src/oozie/templates/editor/list_history.mako
:100644 100644 9582f91... ec80377... M	apps/oozie/src/oozie/templates/editor/list_history_record.mako
:100644 100644 3c51c08... 742c28a... M	apps/oozie/src/oozie/templates/editor/list_trashed_bundles.mako
:100644 100644 ed759d2... cba6731... M	apps/oozie/src/oozie/templates/editor/list_trashed_coordinators.mako
:100644 100644 bd3674d... bf0506e... M	apps/oozie/src/oozie/templates/editor/list_trashed_workflows.mako
:100644 100644 6b0c8c7... 5f9dc5e... M	apps/oozie/src/oozie/templates/editor/list_workflows.mako
:100644 100644 5f0b40f... d0cadaf... M	apps/oozie/src/oozie/templates/navigation-bar.mako
:100644 100644 7e07a81... 9214043... M	apps/pig/src/pig/templates/app.mako
:100644 100644 f44e90e... 7163ba4... M	apps/pig/static/css/pig.css
:100644 100644 955ea16... 114dcea... M	apps/search/src/search/templates/admin_collection_facets.mako
:100644 100644 d96accd... 926b860... M	apps/search/src/search/templates/admin_collection_highlighting.mako
:100644 100644 4c7d1c0... ec3863d... M	apps/search/src/search/templates/admin_collection_properties.mako
:100644 100644 e6e63a8... 842c37d... M	apps/search/src/search/templates/admin_collection_sorting.mako
:100644 100644 d2f6d6d... e8cb42d... M	apps/search/src/search/templates/admin_collection_template.mako
:100644 100644 807623b... f82709b... M	apps/search/src/search/templates/admin_collections.mako
:100644 100644 baa5541... b0acff4... M	apps/search/src/search/templates/search.mako
:100644 100644 bb38607... dd7dfb4... M	apps/search/static/css/admin.css
:100644 100644 44e04fb... 45e97ea... M	apps/search/static/css/search.css
:100644 100644 afde619... b7fa607... M	apps/sqoop/src/sqoop/templates/app.mako
:100644 100644 e5a36b8... 828b1d5... M	apps/sqoop/static/css/sqoop.css
:100644 100644 96205ae... 365d694... M	apps/useradmin/src/useradmin/templates/add_ldap_users.mako
:100644 100644 5ed755f... 103ab1a... M	apps/useradmin/src/useradmin/templates/edit_group.mako
:100644 100644 4c4877d... d972c1a... M	apps/useradmin/src/useradmin/templates/edit_permissions.mako
:100644 100644 ed81920... 167bd54... M	apps/useradmin/src/useradmin/templates/edit_user.mako
:100644 100644 7964099... 2e536b2... M	apps/useradmin/src/useradmin/templates/layout.mako
:100644 100644 133be27... 03dc466... M	apps/useradmin/src/useradmin/templates/list_groups.mako
:100644 100644 1e2e25b... bd356be... M	apps/useradmin/src/useradmin/templates/list_permissions.mako
:100644 100644 786217f... 39e2e8e... M	apps/useradmin/src/useradmin/templates/list_users.mako
:100644 100644 a5ea083... e2266e7... M	apps/useradmin/static/css/useradmin.css
:100644 100644 20075f4... 6172220... M	apps/zookeeper/src/zookeeper/templates/clients.mako
:100644 100644 76eef0e... 954abd1... M	apps/zookeeper/src/zookeeper/templates/create.mako
:100644 100644 ac08be7... 699dd2e... M	apps/zookeeper/src/zookeeper/templates/edit.mako
:100644 100644 88eaff7... 94ee3d3... M	apps/zookeeper/src/zookeeper/templates/index.mako
:100644 100644 6b7fb05... 47cdd90... M	apps/zookeeper/src/zookeeper/templates/shared_components.mako
:100644 100644 14bd16b... 87ea9d9... M	apps/zookeeper/src/zookeeper/templates/tree.mako
:100644 100644 0b73dc8... 9d6e7ab... M	apps/zookeeper/src/zookeeper/templates/view.mako
:100644 100644 41a779c... 83a70f2... M	desktop/core/src/desktop/appmanager.py
:100644 100644 029e6e5... d261580... M	desktop/core/src/desktop/templates/about_layout.mako
:100644 100644 2f8b92b... ad8e5a6... M	desktop/core/src/desktop/templates/common_footer.mako
:100644 100644 9d4e096... 0de5889... M	desktop/core/src/desktop/templates/common_header.mako
:100644 100644 3c194e8... 9963b71... M	desktop/core/src/desktop/templates/dump_config.mako
:100644 100644 9483598... d9c9ef3... M	desktop/core/src/desktop/templates/error.mako
:100644 100644 01983c2... d7ec6b2... M	desktop/core/src/desktop/templates/home.mako
:100644 100644 08a678e... 1cc44c5... M	desktop/core/src/desktop/templates/logs.mako
:100644 100644 324e601... 43d75d3... M	desktop/core/src/desktop/templates/popup_error.mako
:100644 100644 b0f2dfa... 904efb3... M	desktop/core/src/desktop/views.py
:000000 100644 0000000... b9b95d6... A	desktop/core/static/art/hue-logo-mini-white-hover.png
:000000 100644 0000000... 59dea0a... A	desktop/core/static/art/hue-logo-mini-white.png
:000000 100644 0000000... 4e7df6e... A	desktop/core/static/art/icon_hue_24.png
:100644 100644 e5dd9ce... e9a04ea... M	desktop/core/static/css/hue3.css
:100644 100644 83d42e8... ab7afd7... M	desktop/core/static/js/jquery.tour.js
Manual on the 4 major browsers!
  • 0
  • 0
  • 10
  • 4
  • 14
Description From Last Updated
  1. This is super cool!
    
    Just 2-3 main comments!
  2. unused I think
  3. if px is gone, we also need to update the SDK templates:
    
    desktop/core/src/desktop/app_template/src/app_name/templates
  4. apps/beeswax/src/beeswax/templates/layout.mako (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    remove?
  5. apps/hbase/src/hbase/templates/app.mako (Diff revision 1)
     
     
    We don't have access to the current app? (and its icon_path propery)
    
    That would avoid all the according of the icon paths
    
    We could get the current app from the
    
    https://github.com/cloudera/hue/blob/master/desktop/core/src/desktop/context_processors.py#L30
    
    get apps list like in desktop/views.py
    apps = appmanager.get_apps_dict(request.user)
    
    
    {'app': appps.get(app_name), ...}
    1. Opening an additional jira for this one, we don't have the current app everywhere (ie. About) or the app we are in it's not really the one we should display (Beeswax > Metastore)
  6. apps/metastore/src/metastore/templates/components.mako (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
  7. apps/pig/src/pig/templates/app.mako (Diff revision 1)
     
     
    1. It's kinda magic-magic.
      
      Yes, this way is simpler instead of computing it on the fly (that would require calculating the height of all the elements that precedes and follows the editor). 
  8. 29px if no sub-nav bar I guess
  9. If we have the current app, we an get its name with the nice_name attribute too
  10. desktop/core/src/desktop/templates/common_footer.mako (Diff revision 1)
     
     
     
     
     
     
    Why this and not a regular link?
  11. Sure it does not break something?
    
  12. One problem here.
    
    If they are new apps, could we put them in a new 'SDK' or 'Other' section?
    1. Nice catch! Added 'Other apps' section
  13. desktop/core/src/desktop/views.py (Diff revision 1)
     
     
  14. desktop/core/src/desktop/views.py (Diff revision 1)
     
     
    so we have current_app so? ;)
  15. 
      
Review request changed

Status: Closed (submitted)

Loading...