Review Board 1.6.3

FLUME 29 - Compression using gzip before writing file to HDFS

Review Request #377 - discarded 3 years, 8 months ago

anuragphadke Reviewers
FLUME-29 HenryR, jon, phunt
None flume
FLUME-29 adding compression interface before writing files to HDFS
https://issues.cloudera.org/browse/FLUME-29
yes
Review request changed
Updated 3 years, 8 months ago (July 26th, 2010, 10:50 a.m.)
changes per comments below
Posted 3 years, 8 months ago (July 26th, 2010, 5:46 p.m.)

   

  
Putting one's own copyright notice as done in this latest patch is against our policy (sort of like how we don't allow @author tags in the javadoc). One problem is that then everyone who patches the file is tempted to add a copyright for their contributions, this gets ugly fast. We don't try to fully document the reality of the copyright ownership in the source however the commit log / scm will document it, though. That's one of the reasons why we ask contributors to use git's "format-patch", as it maintains this information. Please remove this.
Posted 3 years, 8 months ago (July 26th, 2010, 6:23 p.m.)
Just a few nits, and then I think this looks good!
lowercase boolean would do.
  1. done
phunt will comment on this.
ok, you can stay
  1. yay
    
inside of open.
  1. done
inside open
  1. done
high level comment would be nice. 

  1. comments, now come on :-)
Needs to delete tmp file/dir ( FileUtil.rmr(f); )

  1. done