HUE-1809 [dbquery] autocomplete jdbc class and string

Review Request #3943 — Created Dec. 26, 2013 and submitted

abec
old-hue-rw
HUE-1620, HUE-1808, HUE-1809, HUE-1810
hue
enricoberti, romain
commit da4dc3e35ef8ff794ee81907b65191860e352968
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Thu Dec 26 19:28:21 2013 -0800

    HUE-1809 [dbquery] autocomplete jdbc class and string

:100644 100644 76521e2... 9a238c0... M	apps/sqoop/src/sqoop/templates/app.mako
:100644 100644 6539c62... 0bf630c... M	apps/sqoop/static/js/sqoop.connections.js

commit a3487fe1eaaded06f212136cca3dcf4e961a3406
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Thu Dec 26 15:51:13 2013 -0800

    HUE-1810 [dbquery] autocomplete tables and fields
    
    - table and field autocomplete

:000000 100644 0000000... c342113... A	apps/sqoop/src/sqoop/api/autocomplete.py
:100644 100644 10ca22e... 76521e2... M	apps/sqoop/src/sqoop/templates/app.mako
:100644 100644 2af3ef8... 7a65200... M	apps/sqoop/src/sqoop/urls.py
:000000 100644 0000000... ce13193... A	apps/sqoop/static/js/sqoop.autocomplete.js
:100644 100644 617589b... 6539c62... M	apps/sqoop/static/js/sqoop.connections.js
:100644 100644 0f408a2... 392ea14... M	apps/sqoop/static/js/sqoop.jobs.js
:100644 100644 529f7a5... e721b62... M	apps/sqoop/static/js/sqoop.js

commit beb63b8bfe954edd9d4a74b55f323da7826694b5
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Thu Dec 26 15:01:58 2013 -0800

    HUE-1808 [dbquery] Pull out rdbms config to librdbms app
    
    - Move config to librdbms section.
    - Move server selection to librdbms app.

:100644 100644 5631a9c... 05ef1ff... M	apps/beeswax/src/beeswax/models.py
:100644 100644 c0e7774... 03bdb2f... M	apps/rdbms/src/rdbms/api.py
:100644 100644 54efa6b... d053ec4... M	apps/rdbms/src/rdbms/conf.py
:100644 000000 dd466fa... 0000000... D	apps/rdbms/src/rdbms/design.py
:100644 000000 e69de29... 0000000... D	apps/rdbms/src/rdbms/server/__init__.py
:100644 000000 796e2b6... 0000000... D	apps/rdbms/src/rdbms/server/dbms.py
:100644 000000 6cb6431... 0000000... D	apps/rdbms/src/rdbms/server/mysql_lib.py
:100644 000000 a92e78a... 0000000... D	apps/rdbms/src/rdbms/server/oracle_lib.py
:100644 000000 b015b8e... 0000000... D	apps/rdbms/src/rdbms/server/postgresql_lib.py
:100644 000000 4f7312e... 0000000... D	apps/rdbms/src/rdbms/server/rdbms_base_lib.py
:100644 000000 b6f8b0d... 0000000... D	apps/rdbms/src/rdbms/server/sqlite_lib.py
:100644 100644 63941e3... 6c23d38... M	apps/rdbms/src/rdbms/tests.py
:100644 100644 9344612... 607b9c0... M	apps/rdbms/src/rdbms/views.py
:100644 100644 4db83e7... 6eea5c8... M	apps/sqoop/src/sqoop/api/__init__.py
:100644 100644 05ba959... c98a990... M	desktop/Makefile
:100644 100644 12f80bc... 9337904... M	desktop/conf.dist/hue.ini
:100644 100644 1b7de4f... 1d2f4b6... M	desktop/conf/pseudo-distributed.ini.tmpl
:000000 100644 0000000... 1bda9cf... A	desktop/libs/librdbms/Makefile
:000000 100644 0000000... 0bc257f... A	desktop/libs/librdbms/babel.cfg
:000000 100644 0000000... d65237e... A	desktop/libs/librdbms/setup.py
:000000 100644 0000000... 1854b36... A	desktop/libs/librdbms/src/librdbms/__init__.py
:000000 100644 0000000... 52c8fa4... A	desktop/libs/librdbms/src/librdbms/conf.py
:000000 100644 0000000... dd466fa... A	desktop/libs/librdbms/src/librdbms/design.py
:000000 100644 0000000... 3c96a6f... A	desktop/libs/librdbms/src/librdbms/locale/de/LC_MESSAGES/django.po
:000000 100644 0000000... a29a37b... A	desktop/libs/librdbms/src/librdbms/locale/en/LC_MESSAGES/django.po
:000000 100644 0000000... 2dda0f4... A	desktop/libs/librdbms/src/librdbms/locale/en_US.pot
:000000 100644 0000000... 1185319... A	desktop/libs/librdbms/src/librdbms/locale/es/LC_MESSAGES/django.po
:000000 100644 0000000... 58c1d33... A	desktop/libs/librdbms/src/librdbms/locale/fr/LC_MESSAGES/django.po
:000000 100644 0000000... 68b022c... A	desktop/libs/librdbms/src/librdbms/locale/ja/LC_MESSAGES/django.po
:000000 100644 0000000... c8cdd54... A	desktop/libs/librdbms/src/librdbms/locale/ko/LC_MESSAGES/django.po
:000000 100644 0000000... 7f0e871... A	desktop/libs/librdbms/src/librdbms/locale/pt/LC_MESSAGES/django.po
:000000 100644 0000000... 4969a9c... A	desktop/libs/librdbms/src/librdbms/locale/pt_BR/LC_MESSAGES/django.po
:000000 100644 0000000... 0d3da2d... A	desktop/libs/librdbms/src/librdbms/locale/zh_CN/LC_MESSAGES/django.po
:000000 100644 0000000... d053ec4... A	desktop/libs/librdbms/src/librdbms/models.py
:000000 100644 0000000... e69de29... A	desktop/libs/librdbms/src/librdbms/server/__init__.py
:000000 100644 0000000... 0158d83... A	desktop/libs/librdbms/src/librdbms/server/dbms.py
:000000 100644 0000000... 3478a7a... A	desktop/libs/librdbms/src/librdbms/server/mysql_lib.py
:000000 100644 0000000... 8a57259... A	desktop/libs/librdbms/src/librdbms/server/oracle_lib.py
:000000 100644 0000000... d003e9e... A	desktop/libs/librdbms/src/librdbms/server/postgresql_lib.py
:000000 100644 0000000... 0210528... A	desktop/libs/librdbms/src/librdbms/server/rdbms_base_lib.py
:000000 100644 0000000... 10ad8de... A	desktop/libs/librdbms/src/librdbms/server/sqlite_lib.py
:000000 100644 0000000... d053ec4... A	desktop/libs/librdbms/src/librdbms/tests.py
:000000 100644 0000000... d053ec4... A	desktop/libs/librdbms/src/librdbms/urls.py
tested manually.
  • 1
  • 0
  • 3
  • 0
  • 4
Description From Last Updated
hope the lib does not depend on Beeswax :) romain romain
romain
  1. Niice!!
    
    This is great! 
    
    HUE-1809 [dbquery]
    HUE-1810 [dbquery]
    
    --> [sqoop]
    
    
    Could be done here or in another jira maybe:
    We could add a help link/icon in sqoop DB page pointing to RDBMS and saying to configure it in order to get autocompletion and manually explore the DB (another link that opens on the DB/table/select *?).
    
    We can even have links between Sqoop <--> RDMBS for good iterations before sqooping at some point and maybe prefill connection settings in Sqoop (3.7 or 3.8 aka 4.0 when we go 'one more level up).
    1. Good catch.
      
      I think you're right... let's add that link in another jira.
      
      Another thought I had was that I am changing configs from Hue 3 -> Hue 3.5 (really just the section name). I didn't think it would be too much of an issue though since nothing packaged the dbquery app until much later.
  2. apps/beeswax/src/beeswax/models.py (Diff revision 1)
     
     
    hope the lib does not depend on Beeswax :)
    1. The lib doesn't have a hard dependency on beeswax (made sure of that). There is, however, a dependency on QueryHistory I believe. The dependency is created calling 'execute_query' in dbms.py. There is also a weird-ish connection point (which you've teased out here) with regards to names of the databases.
  3. apps/sqoop/src/sqoop/api/autocomplete.py (Diff revision 1)
     
     
     
     
     
     
    maybe just do a
    
    if all([param == param for param in check])):
      return config
    
    to get rid of the valid flag
  4. apps/sqoop/src/sqoop/templates/app.mako (Diff revision 1)
     
     
     
    maybe indend return and remove break
  5. desktop/conf.dist/hue.ini (Diff revision 1)
     
     
    We could add a note in [sqoop] saying for autocompletion fill up [rdbms]?
  6. 
      
abec
abec
abec
Review request changed

Status: Closed (submitted)

Loading...