HUE-1828 [beeswax] Add back download and save results

Review Request #3962 — Created Jan. 2, 2014 and submitted

abec
old-hue-rw
HUE-1828
hue
enricoberti, romain
commit 2651aa2392957698e6ca68ec509b0ec0d48cd649
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Tue Dec 31 13:16:06 2013 -0800

    HUE-1828 [beeswax] Add back download and save results
    
    Make save results more ajaxy.
    Fix save results tests.

:100644 100644 e7fd187... 5d817ef... M  apps/beeswax/src/beeswax/api.py
:100644 100644 a11cd30... b2a395e... M  apps/beeswax/src/beeswax/forms.py
:100644 100644 293656f... 70e7783... M  apps/beeswax/src/beeswax/templates/execute.mako
:100644 100644 c61540e... 50d1187... M  apps/beeswax/src/beeswax/tests.py
:100644 100644 ca4bf04... 5dbab90... M  apps/beeswax/src/beeswax/urls.py
:100644 100644 8b2dae5... ad8db16... M  apps/beeswax/src/beeswax/views.py
:100644 100644 6c5c9d3... 853a5cc... M  apps/beeswax/static/js/beeswax.vm.js
:100644 100644 50a00a5... b48f386... M  desktop/core/src/desktop/lib/django_forms.py
Ran test all
Manually tested download and save results. Also error states.
  • 0
  • 0
  • 0
  • 2
  • 2
Description From Last Updated
romain
  1. Nice!
    
    Let's just update the tests with the new views
  2. apps/beeswax/src/beeswax/api.py (Diff revision 1)
     
     
    we should add/update the tests for the new views too:
    
    test_save_results_to_dir
    test_save_results_to_tbl
    1. They are indeed updated in this review.
  3. None is default already?
    1. I've found that it isn't actually. This throws an exception otherwise.
  4. 
      
romain
  1. Ship It!
  2. 
      
abec
Review request changed

Status: Closed (submitted)

Loading...