HUE-1686 [beeswax] Saving results should not re-execute the query

Review Request #4104 — Created Feb. 7, 2014 and submitted

abec
old-hue-rw
HUE-1686
hue
enricoberti, romain
commit b4ee4434fd91747245dffb161764edf002497ca2
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Fri Feb 7 16:57:22 2014 -0800

    HUE-1686 [beeswax] Saving results should not re-execute the query
    
    Save as CSV format only.

:100644 100644 dd2b6bb... ee3f933... M	apps/beeswax/src/beeswax/api.py
:100644 100644 26c7087... 888215c... M	apps/beeswax/src/beeswax/data_export.py
:100644 100644 75b969e... 093e7ed... M	apps/beeswax/src/beeswax/forms.py
:100644 100644 819ffa1... 554e81d... M	apps/beeswax/src/beeswax/templates/execute.mako
:100644 100644 dc11e09... 7412426... M	apps/beeswax/src/beeswax/tests.py
:100644 100644 f317188... 6960b2a... M	apps/beeswax/static/js/beeswax.vm.js
:100644 100644 78b9550... c47ccd5... M	desktop/core/src/desktop/lib/export_csvxls.py
ran beeswax tests.
  • 0
  • 0
  • 5
  • 2
  • 7
Description From Last Updated
romain
  1. Nice!
    
    This will pave the way for a more complete export wizard :)
  2. apps/beeswax/src/beeswax/api.py (Diff revision 1)
     
     
    do_as current user
  3. apps/beeswax/src/beeswax/api.py (Diff revision 1)
     
     
     
     
     
     
     
    refactor it up above line # 422 with line 424-429
  4. apps/beeswax/src/beeswax/data_export.py (Diff revision 1)
     
     
    we should do as do_as user too
  5. apps/beeswax/src/beeswax/forms.py (Diff revision 1)
     
     
    Label 'Rerun query' --> 'Huge result, run an export query'
    
    At some point, we should probably remove this button:
    - and see if HS2 can provide the path to the result, HIVE-5905
    - Impala won't have this option before a while, but they might have a persist to disk option this year
    
    We will have to refactor the export and make it a wizard with hadoop formats, use header or not... etc anyway
    1. How about "Run an export query". Huge result is misleading.
  6. apps/beeswax/src/beeswax/forms.py (Diff revision 1)
     
     
    let's default to false
  7. apps/beeswax/src/beeswax/tests.py (Diff revision 1)
     
     
    + check content len or some rows at least?
  8. apps/beeswax/src/beeswax/tests.py (Diff revision 1)
     
     
    check list of files? Should be one file and could check it content
    
    1. We do in the method higher up.
  9. 
      
abec
romain
  1. 
      
  2. apps/beeswax/src/beeswax/forms.py (Diff revisions 1 - 2)
     
     
    Ok, rename just to 'Run an export query'
  3. 
      
abec
abec
Review request changed

Status: Closed (submitted)

Loading...