HUE-1858 [oozie] "Could not save workflow" error message requires substantially more information
Review Request #4120 — Created Feb. 10, 2014 and submitted
commit 0aa4259585d5757b1c3f4ac8a3387f5693227dbb Author: Abraham Elmahrek <firstname.lastname@example.org> Date: Mon Feb 10 15:00:37 2014 -0800 HUE-1858 [oozie] "Could not save workflow" error message requires substantially more information Also fix 3 tier graph with decisions and forks. Improve general error handling. :100644 100644 fe09255... 69477f0... M apps/oozie/src/oozie/templates/editor/edit_workflow.mako :100644 100644 6a0a00d... ab39a73... M apps/oozie/src/oozie/tests.py :100644 100644 bf8f44e... 5b226e6... M apps/oozie/src/oozie/views/api.py :100644 100644 efdfb63... d5c6913... M apps/oozie/static/js/workflow.js
Verified 3 tier graph as described in HUE-1874. Before fixing HUE-1874, verified broken state uses proper error messaging. Added a couple of tests to verify error codes. Tried creating a node w/ error, importing a node w/ error, and saving a workflow w/ error.
Nice! And I would rather keep the traceback out of the end user view ;)
cf. comment below
Are we just failing because we did a POST instead of GET? (we could test with a real exception a bit like test_workflow_fail, e.g. call to Oozie just fails?)
Do we really need the tb as the trace is in the /logs ? (and we should not show it to the end user)