HUE-1949 [impala] Friendler query expiration message

Review Request #4150 — Created Feb. 20, 2014 and submitted

abec
old-hue-rw
HUE-1949
hue
enricoberti, romain
commit 4ae1d910b7013454ed6870c75cf8596f99d1b5da
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Thu Feb 20 15:34:25 2014 -0800

    HUE-1949 [impala] Friendler query expiration message
    
    Update status of queries that are closed.
    Fix error listing.

:100644 100644 94f59c5... ed53e7b... M	apps/beeswax/src/beeswax/tests.py
:100644 100644 7602058... 656e92f... M	apps/beeswax/src/beeswax/views.py
:100644 100644 cba83d7... 86c8234... M	apps/beeswax/static/js/beeswax.vm.js
Added a test case and ran it.
Tested manually that redirection and error message appears appropriately.
Also manually tested result errors are being reset.
  • 0
  • 0
  • 6
  • 1
  • 7
Description From Last Updated
romain
  1. 
      
  2. apps/beeswax/src/beeswax/tests.py (Diff revision 1)
     
     
    why not retrieve again the query_history and check that its status is expired?
  3. apps/beeswax/src/beeswax/views.py (Diff revision 1)
     
     
    same error message with HS2 too?
    1. Good point. For HS2 it's "Invalid OperationHandle: OperationHandle [opType=EXECUTE_STATEMENT, getHandleIdentifier()=7c83d098-cb4b-4c63-9879-ab1845d8788b]". I'll discern between the two.
  4. apps/beeswax/src/beeswax/views.py (Diff revision 1)
     
     
    If the query has expired, we should load back the query but have an empty result.
    
    For now the red alert is good but ideally we should have a message similar to ':( The operation did not return any result' 
    1. Sounds good. Will log the errors instead.
  5. 
      
abec
romain
  1. Nice!!
  2. The result has expired, rerun the query if needed
  3. apps/beeswax/src/beeswax/views.py (Diff revision 2)
     
     
  4. apps/beeswax/src/beeswax/views.py (Diff revision 2)
     
     
    or just "Invalid query handle: %s" % e?
    1. Adding it here actually formats the exception for us.
  5. apps/beeswax/src/beeswax/views.py (Diff revision 2)
     
     
    remove \n
  6. 
      
abec
Review request changed

Status: Closed (submitted)

Loading...