HUE-1933 [beeswax] Do not fetch query handle for bad queries

Review Request #4155 — Created Feb. 21, 2014 and submitted

abec
old-hue-rw
HUE-1933
hue
enricoberti, romain
commit 2ebc313aa13d072a51d6e8bbd02e86c27d3f527d
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Fri Feb 21 16:32:53 2014 -0800

    HUE-1933 [beeswax] Do not fetch query handle for bad queries

:100644 100644 3a31816... 1e5d519... M	apps/beeswax/src/beeswax/views.py
Ran all beeswax tests.
This scenario will not come up in practice, but it's good to test.
romain
  1. Not in practice but happens in the tests?
    1. The tests are covering a case that will only happen if the user explicitly goes into the database, looks up with query history ID, and goes to the page with that query history. If a query is executed, but fails, then a design will be created (aka saved), but the QueryHistory object will not be displayed as if it has results. We link to the "saved" design rather than the query history if no results need to be displayed.
      
      This is a good thing to test though because it makes sure that if we ever deviate from this pattern, then we'll know it at least works.
  2. 
      
abec
Review request changed

Status: Closed (submitted)

Loading...