HUE-2040 [useradmin] Synchronize nested ldap groups

Review Request #4286 — Created March 24, 2014 and submitted

abec
old-hue-rw
HUE-2040
hue
enricoberti, romain
commit d03d96fcb8f7125c85844ac9384cdf22928ad119
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Mon Mar 24 12:00:40 2014 -0700

    HUE-2040 [useradmin] Synchronize nested ldap groups
    
    Split up nested group and suboordinate group handling.
    Add group synchronization logic in a separate method for nested groups.
    Posix groups cannot have nested groups, so if it is nested,
    its users are imported and we don't go any further.
    NOTE: Synchronization should on assign existing users to existing groups.

:100644 100644 94f415f... 15c3be4... M	apps/useradmin/src/useradmin/forms.py
:100644 100644 da6b83a... 7973cb6... M	apps/useradmin/src/useradmin/tests.py
:100644 100644 c467b25... c354571... M	apps/useradmin/src/useradmin/views.py

commit 0d27c24df17e459c022fe546614f608301dcf1b5
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Mon Mar 24 14:30:36 2014 -0700

    [core] make suboordinate subgroups the default

:100644 100644 ab8ca78... bc05efd... M	desktop/core/src/desktop/conf.py

commit 9c74f838311404b9ce051d4e7084c36d73b408ed
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Mon Mar 24 13:37:35 2014 -0700

    [core] remove bad import from python util tests

:100644 100644 22eb6a5... 067ead3... M	desktop/core/src/desktop/lib/python_util_test.py
Ran test fast and tested nested synchronization manually via the command line.
  • 2
  • 0
  • 3
  • 0
  • 5
Description From Last Updated
sure that we don't aggregate? romain romain
better to stop? romain romain
romain
  1. Impressive!
    
    Are we cool with the backward compatibility? (or would it be a very improbable scenario of breaking)
    1. The default "grouping" change is to provide better backwards compatibility. The tests are passing and things are working as expected, but I'm going to have to go through these LDAP configs before our next release (just in case).
  2. apps/useradmin/src/useradmin/views.py (Diff revision 1)
     
     
    sure that we don't aggregate?
    1. Returning a set isn't needed any more. Will remove.
  3. apps/useradmin/src/useradmin/views.py (Diff revision 1)
     
     
    better to stop?
    1. The previous behavior is to stop. We could change in a follow? Would rather minimize the amount of functionality changes this patch brings (as it brings many already).
  4. apps/useradmin/src/useradmin/views.py (Diff revision 1)
     
     
    python 2.4, I know you talked about Hue 2 but I am cool to focus on Hue 3 only
  5. desktop/core/src/desktop/conf.py (Diff revision 1)
     
     
    hue.inis update?
  6. 
      
romain
  1. 
      
  2. apps/useradmin/src/useradmin/views.py (Diff revision 1)
     
     
    cool to fail silently here and below?
    1. Yep. If the user doesn't exist, then it shouldn't be sync'd. Adding debug logging though.
  3. 
      
abec
romain
  1. Ship It!
  2. 
      
abec
Review request changed

Status: Closed (submitted)

Loading...