HUE-2026 [core] Create a doc model write permission

Review Request #4296 — Created March 28, 2014 and submitted

abec
old-hue-rw
HUE-2026
hue
enricoberti, romain
commit b24dae5b5ef28ecf101516b69633e565e3b130a0
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Fri Mar 14 17:02:02 2014 -0700

    HUE-2026 [core] Create a doc model write permission
    
    Add permission 'modify'.
    Implicit read permission with 'modify'.
    Modify pig and oozie apps to use 'can_modify' when
    allowing other users to write.

:100644 100644 47e37d0... c68c942... M	apps/beeswax/src/beeswax/views.py
:100644 100644 a18c953... 8ec07fe... M	apps/oozie/src/oozie/models.py
:100644 100644 5743ec1... 53b86cf... M	apps/pig/src/pig/models.py
:100644 100644 5b1f159... 9c1d936... M	apps/pig/src/pig/templates/app.mako
:100644 100644 45c550b... 4027b6d... M	apps/pig/static/js/pig.ko.js
:100644 100644 57af8c0... f24cd35... M	desktop/core/src/desktop/api.py
:100644 100644 fddbb94... cc2bc19... M	desktop/core/src/desktop/api_tests.py
:100644 100644 ad1af98... a8102ac... M	desktop/core/src/desktop/models.py
:100644 100644 708d1ae... c8e8f2c... M	desktop/core/src/desktop/templates/home.mako
:100644 100644 252d0b1... e7357d3... M	desktop/core/static/js/home.vm.js
ran test fast and manually verified that users can modify based on the existence of the 'modify' perm.
Loading file attachments...

  • 2
  • 0
  • 7
  • 0
  • 9
Description From Last Updated
is there a way to simplify by using selectedDoc().perms only? romain romain
ditto romain romain
romain
  1. Nice!
    
    Maybe some followup UX later with Enrice
  2. desktop/core/src/desktop/models.py (Diff revision 1)
     
     
    I guess that a doc is readable automatically if there is a perm so we could remove the comment:
    
    # Check for READ perm only, not write
  3. desktop/core/src/desktop/models.py (Diff revision 1)
     
     
    DocumentPermission.MODIFY_PERM
  4. is there a way to simplify by using selectedDoc().perms only?
    1. What did you have in mind? I didn't want to make these things observables since there were other aspects of the front end that tied into it.
  5. desktop/core/src/desktop/templates/home.mako (Diff revision 1)
     
     
     
     
     
    Can the text of the select one be visible? (like gdoc) that way it is easily readable
    
    We can see with Enrice if needed!
    
    Also we should probably have an icon or other color code for representing what is R/W in the modal or in the share column.
    1. How about we merge users and  groups and make it more implicit like drive. See attached file.
  6. 
      
abec
romain
  1. + shouldn't we be consistent with the perm names? READ, WRITE... then it looks cohesive and cleaner
    1. Write perm, but the user sees modify maybe?
    2. Sure, we can put the text label we want in the UI!
  2. 
      
abec
romain
  1. 
      
  2. apps/pig/src/pig/models.py (Diff revision 1)
     
     
  3. apps/pig/src/pig/models.py (Diff revision 1)
     
     
  4. apps/pig/static/js/pig.ko.js (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
  5. 
      
abec
Review request changed

Status: Closed (submitted)

Loading...