[core] Add BeautifulSoup and have requests use it

Review Request #4315 — Created April 16, 2014 and submitted

abec
old-hue-rw
hue
enricoberti, romain
commit 9f1377516f60c37bf5b6735055fcb750a1f31436
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Wed Apr 16 20:58:40 2014 +0300

    [core] Add BeautifulSoup and have requests use it
    
    Replace charade with BeautifulSoup which has an MIT license.

:100644 100644 b9a1de1... 31e3a70... M	desktop/core/ext-py/requests-2.0.0/NOTICE
:100644 100644 837f0df... 21e603e... M	desktop/core/ext-py/requests-2.0.0/requests/__init__.py
:100644 100644 0d61a57... 9f1bfb5... M	desktop/core/ext-py/requests-2.0.0/requests/compat.py
:100644 100644 8fd9735... 14394e1... M	desktop/core/ext-py/requests-2.0.0/requests/models.py
:000000 100644 0000000... 7ba3426... A	desktop/core/ext-py/requests-2.0.0/requests/packages/bs4/__init__.py
:000000 100644 0000000... 740f5f2... A	desktop/core/ext-py/requests-2.0.0/requests/packages/bs4/builder/__init__.py
:000000 100644 0000000... 7de36ae... A	desktop/core/ext-py/requests-2.0.0/requests/packages/bs4/builder/_html5lib.py
:000000 100644 0000000... ca8d8b8... A	desktop/core/ext-py/requests-2.0.0/requests/packages/bs4/builder/_htmlparser.py
:000000 100644 0000000... fa5d498... A	desktop/core/ext-py/requests-2.0.0/requests/packages/bs4/builder/_lxml.py
:000000 100644 0000000... 59640b7... A	desktop/core/ext-py/requests-2.0.0/requests/packages/bs4/dammit.py
:000000 100644 0000000... 4d0b00a... A	desktop/core/ext-py/requests-2.0.0/requests/packages/bs4/diagnose.py
:000000 100644 0000000... da9afdf... A	desktop/core/ext-py/requests-2.0.0/requests/packages/bs4/element.py
:000000 100644 0000000... fd4495a... A	desktop/core/ext-py/requests-2.0.0/requests/packages/bs4/testing.py
:000000 100644 0000000... 142c8cc... A	desktop/core/ext-py/requests-2.0.0/requests/packages/bs4/tests/__init__.py
:000000 100644 0000000... 92ad10f... A	desktop/core/ext-py/requests-2.0.0/requests/packages/bs4/tests/test_builder_registry.py
:000000 100644 0000000... 5b9f677... A	desktop/core/ext-py/requests-2.0.0/requests/packages/bs4/tests/test_docs.py
:000000 100644 0000000... 594c3e1... A	desktop/core/ext-py/requests-2.0.0/requests/packages/bs4/tests/test_html5lib.py
:000000 100644 0000000... bcb5ed2... A	desktop/core/ext-py/requests-2.0.0/requests/packages/bs4/tests/test_htmlparser.py
:000000 100644 0000000... 2b2e9b7... A	desktop/core/ext-py/requests-2.0.0/requests/packages/bs4/tests/test_lxml.py
:000000 100644 0000000... 47ac245... A	desktop/core/ext-py/requests-2.0.0/requests/packages/bs4/tests/test_soup.py
:000000 100644 0000000... f8515c0... A	desktop/core/ext-py/requests-2.0.0/requests/packages/bs4/tests/test_tree.py
:100644 000000 1aadf3e... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/__init__.py
:100644 000000 65bffc0... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/big5freq.py
:100644 000000 7382f7c... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/big5prober.py
:100644 000000 dfd3355... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/chardistribution.py
:100644 000000 2959654... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/charsetgroupprober.py
:100644 000000 9758171... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/charsetprober.py
:100644 000000 1bda9ff... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/codingstatemachine.py
:100644 000000 d9e30ad... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/compat.py
:100644 000000 a3d27de... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/constants.py
:100644 000000 543501f... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/cp949prober.py
:100644 000000 0063935... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/escprober.py
:100644 000000 1cf3aa6... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/escsm.py
:100644 000000 d70cfbb... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/eucjpprober.py
:100644 000000 a179e4c... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/euckrfreq.py
:100644 000000 def3e42... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/euckrprober.py
:100644 000000 576e750... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/euctwfreq.py
:100644 000000 e601adf... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/euctwprober.py
:100644 000000 1238f51... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/gb2312freq.py
:100644 000000 643fe25... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/gb2312prober.py
:100644 000000 90d171f... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/hebrewprober.py
:100644 000000 064345b... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/jisfreq.py
:100644 000000 b4e6af4... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/jpcntx.py
:100644 000000 ea5a60b... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/langbulgarianmodel.py
:100644 000000 15e338f... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/langcyrillicmodel.py
:100644 000000 93241ce... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/langgreekmodel.py
:100644 000000 d871324... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/langhebrewmodel.py
:100644 000000 6f59c61... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/langhungarianmodel.py
:100644 000000 df343a7... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/langthaimodel.py
:100644 000000 bebe1bc... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/latin1prober.py
:100644 000000 1eee253... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/mbcharsetprober.py
:100644 000000 2f6f5e8... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/mbcsgroupprober.py
:100644 000000 55c02f0... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/mbcssm.py
:100644 000000 da26715... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/sbcharsetprober.py
:100644 000000 b224814... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/sbcsgroupprober.py
:100644 000000 9bb0cdc... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/sjisprober.py
:100644 000000 6175bfb... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/universaldetector.py
:100644 000000 72c8d3d... 0000000... D	desktop/core/ext-py/requests-2.0.0/requests/packages/charade/utf8prober.py
:100755 100755 7de446f... 109a5d2... M	desktop/core/ext-py/requests-2.0.0/setup.py
tested against filebrowser and oozie. Tried with Japanese named files.

Backup strategy will be to install chardet if some content cannot be decoded.
romain
  1. This is nice!
    
    Wondering, why Beautifulsoup and not chardet?
    1. chardet is LGPL. It can use chardet libraries if they are installed though. So this will be a backup plan if something isn't working correctly.
  2. 
      
romain
  1. Ship It!
  2. 
      
abec
Review request changed

Status: Closed (submitted)

Loading...