[useradmin] LDAP username field should accept spaces

Review Request #4360 — Created May 23, 2014 and submitted

abec
old-hue-rw
HUE-2117
hue
enricoberti, romain
commit f17f991d86566357c230160449c515b0638488c6
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Fri May 23 14:31:49 2014 -0700

    [useradmin] LDAP username field should accept spaces
    
    - username should not have size restriction when using DN
    - groupname should not have size restriction when using DN

:100644 100644 c3ca8de... 1f156e9... M  apps/useradmin/src/useradmin/forms.py
:100644 100644 315043a... 35cfa80... M  apps/useradmin/src/useradmin/test_ldap.py
:100644 100644 ad49cbc... f8b6c61... M  apps/useradmin/src/useradmin/test_ldap_deprecated.py
:100644 100644 54fc739... 85294cb... M  apps/useradmin/src/useradmin/tests.py
:100644 100644 ebb237b... 0a4f354... M  apps/useradmin/src/useradmin/views.py
Ran test fast + manual testing.
Added validation to useradmin import method to ensure proper usernames are being imported. Group names are less strict.
romain
  1. Bit confused, I though the whole point was to allow white spaces?
    1. It's to allow white spaces for DNs. These are the circumstances being handled with this patch:
      1. When a DN is being provided, it may have spaces. The corresponding username retrieved from LDAP should not have spaces nor colons.
      2. When a username is provided, it should not have spaces nor colons.
      3. Group names can have any character apparently.
    2. Could you add your 3 bullet points in the commit + maybe change the title to something like 'LDAP DN name should accept spaces'
      
      '
  2. 
      
romain
  1. Ship It!
  2. 
      
abec
Review request changed

Status: Closed (submitted)

Loading...