HUE-2166 [core] Oracle database support in doc model

Review Request #4450 - Created June 13, 2014 and submitted

Abraham Elmahrek
old-hue-rw
HUE-2166
hue
enricoberti, romain
commit 42f9917b512413addb9855cd882d5b1506bb6e44
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Fri Jun 13 14:40:39 2014 -0700

    HUE-2166 [core] Oracle database support in doc model

:100644 100644 cce8416... 130d91b... M	desktop/core/src/desktop/migrations/0007_auto__add_documentpermission__add_documenttag__add_document.py
:000000 100644 0000000... bf4aac2... A	desktop/core/src/desktop/migrations/0008_documentpermission_m2m_tables.py
:000000 100644 0000000... befa81e... A	desktop/core/src/desktop/migrations/0009_auto__chg_field_document_name.py
:100644 100644 eafd0d9... 4695e19... M	desktop/core/src/desktop/models.py
Migrations work for the following cases:
- Brand new install.
- Existing installation.

Data may go missing unfortunately... Thought of introspecting for database names and columns names for oracle only? Seems a bit overkill. Users should probably just perform a "dumpdata" and reload the data.

This does not fix the "ORA-00932: inconsistent datatypes: expected - got NCLOB" errors.
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
  1. 
      
  2. desktop/core/src/desktop/migrations/0008_documentpermission_m2m_tables.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Hum, will upgrading nuke all the existing permissions?
    1. Indeed it will. There doesn't seem to be a good way of copying that data without doing a ridiculous amount of introspection and guessing. I can remove the delete_table statements... but a lot of that transfer work will need to be manual I think.
  3. 
      
  1. Looks good! So basically we create the tables with a shorter name. Existing 5.0 installation that upgrade are going to work because 0008 also add them in case.
    
    Two last comments:
    #1 Normally the only drawback is that all the perms of C5.0 are lost. There is no way to rename the table instead in 0008_documentpermission_m2m_tables.py?
    #2 Is install examples working correctly?
    1. Rename will be difficult since we have no good way to tell what the table names will be. Example:
      DESKTOP_DOCUMENTPERMISSIONBC87
      DESKTOP_DOCUMENTPERMISSIONFF03
      We could look for column names, but it seems like overkill and may be difficult across databases.
      
      Examples are installing.
      
  2. 
      
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Loading...