Review Request for HUE-2192

Review Request #4467 - Created June 24, 2014 and submitted

Chris Conner
old-hue
master
HUE-2192
hue
abec, enricoberti, romain
Added an option to set LDAP_USERNAME for HS2 calls.
Was not able to test since I don't have HS2 with Ldap setup.  However, did update the beeswax tests to do a check.
  • 0
  • 0
  • 6
  • 0
  • 6
Description From Last Updated
  1. Nice!!
    
    Could we just fix the tests?
  2. LDAP_PASSWORD, LDAP_USERNAME
  3. apps/beeswax/src/beeswax/tests.py (Diff revision 1)
     
     
     
     
    indent 2 back?
  4. apps/beeswax/src/beeswax/tests.py (Diff revision 1)
     
     
    for f in finish:
      f()
  5. desktop/conf.dist/hue.ini (Diff revision 1)
     
     
     
  6. desktop/conf/pseudo-distributed.ini.tmpl (Diff revision 1)
     
     
     
    Not your fault but could we double the ## for the values, e.g.:
    
    ## ldap_username=hue
    ## ldap_password=
  7. 
      
  1. We had to update the tests, I think we should wait for my commit then tweak the test part only cf. below comment. The other part of the review is great!
    1. Cool, let me know when yours is committed and Ben and I will adjust.
    2. pushed!
  2. apps/beeswax/src/beeswax/tests.py (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    We should remove these ones and instead add a new line 2014-2018
    
    https://review.cloudera.org//r/4473/diff/#index_header
  3. 
      
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Loading...