HUE-2796 [core] Fixed several sync_groups_on_login issues including posix

Review Request #5343 - Created June 4, 2015 and submitted

Chris Conner
hue
HUE-1071
HUE-2693, HUE-2790, HUE-2791, HUE-2796
96c5a27...
hue
enricoberti, erickt, romain

commit 0bea9cfecc471a5bd864cc0eb62e646ced4f7903
Author: Chris Conner <cconner@cloudera.com>
Date: Thu Jun 4 13:26:20 2015 -0400

[HTML_REMOVED] HUE-2796 [core] Fixed several sync_groups_on_login issues including posix

:100644 100644 616cc17... 01f791e... M apps/useradmin/src/useradmin/views.py
:100644 100644 5bd158d... cef2f51... M desktop/core/src/desktop/auth/backend.py

Tested the following:

  1. Adding users to several groups and logging in as all the users.
  2. Removing users from several groups and logging in as all the users.
  3. Adding and removing users from various groups and logging in as those users.
  4. Tested the above with posixAccounts/posixGroups
  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
  1. Nice!!

    Tests are still passing? ;)

    build/env/bin/hue test specific useradmin

  2. apps/useradmin/src/useradmin/views.py (Diff revision 1)
     
     
     
     
     
     
     
     
     

    this block could be moved below this if and removed in the else?

    (seems like the code is the same in if/else) and can be safely just be moved outside if group_ldap_info is initialized to [] before

  3. apps/useradmin/src/useradmin/views.py (Diff revision 1)
     
     

    delete?

    1. I couldn't figure out why the "remove_ldap_groups.delete()" was in there, I'm guessing maybe to try and delete groups that were empty? If that is the case, I don't think we want that anyhow, they should manually delete groups they don't want. All the above was doing was removing entries from "useradmin_ldapgroup" which was wreaking all sorts of havoc on the syncing of ldap users and groups.

  4. 
      
  1. Ship It!

  2. 
      
Review request changed

Status: Closed (submitted)

Loading...