Solr Smart Indexer

Review Request #7789 - Created June 15, 2016 and submitted

Aaron Peddle
hue
solr-smart-indexer
hue
romain
commit b4c9ada2c0194d8beb798cd26b25a8fb364f160e
Author: Aaron Peddle <aaron.peddle@cloudera.com>
Date:   Wed Jun 15 13:22:55 2016 -0700

    solr smart indexer end to end

:100644 100644 4572726... 079343e... M	desktop/libs/indexer/src/data/solrconfigs/solrcloud/conf/solrconfig.xml
:100644 000000 114eb60... 0000000... D	desktop/libs/indexer/src/indexer/indexer.py
:100644 000000 b6739d3... 0000000... D	desktop/libs/indexer/src/indexer/simple.csv
:000000 100644 0000000... a56093a... A	desktop/libs/indexer/src/indexer/smart_indexer.py
:100644 100644 e46490d... b776392... M	desktop/libs/indexer/src/indexer/templates/morphline_template.conf
:000000 100644 0000000... 71e0daa... A	desktop/libs/indexer/src/indexer/tests_indexer.py
:100644 100644 ddf7219... 06f413b... M	desktop/libs/libsolr/src/libsolr/api.py

commit 451909e5d4dda0a1e0b1142b7a5a553cc826bd3a
Author: peddle <peddle.aaron@gmail.com>
Date:   Fri Jun 3 11:02:08 2016 -0700

    simple indexer api for basic csv case

:000000 100644 0000000... 114eb60... A	desktop/libs/indexer/src/indexer/indexer.py
:000000 100644 0000000... b6739d3... A	desktop/libs/indexer/src/indexer/simple.csv
:000000 100644 0000000... e46490d... A	desktop/libs/indexer/src/indexer/templates/morphline_template.conf
:000000 100644 0000000... ffbb616... A	desktop/libs/indexer/src/indexer/templates/schema.mako


  • 12
  • 0
  • 0
  • 0
  • 12
Description From Last Updated
Does current indexer still work with that? Romain Rigaux
Add Cloudera license on top? Romain Rigaux
reorder imports by section? import json import logging from mako.template import Template from hadoop import cluster from liboozie.oozie_api import get_oozie ... Romain Rigaux
indentation -2 space? Romain Rigaux
) on new line? Romain Rigaux
convert two new lines to one? Romain Rigaux
move to top? Romain Rigaux
remove extra new lines? Romain Rigaux
Can remove this and add licence Romain Rigaux
Add top licence? Romain Rigaux
same comments about organization of top of file Romain Rigaux
can be removed? Romain Rigaux
  1. 
      
  2. Does current indexer still work with that?

  3. Add Cloudera license on top?

  4. reorder imports by section?

    import json
    import logging

    from mako.template import Template

    from hadoop import cluster

    from liboozie.oozie_api import get_oozie
    from liboozie.submission2 import Submission

  5. indentation -2 space?

  6. desktop/libs/indexer/src/indexer/smart_indexer.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     

    convert two new lines to one?

  7. remove extra new lines?

  8. Can remove this and add licence

  9. same comments about organization of top of file

  10. desktop/libs/indexer/src/indexer/tests_indexer.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    can be removed?

  11. 
      
Review request changed

Status: Closed (submitted)

Loading...