HBASE-2997 performance improvements

Review Request #843 — Created Sept. 14, 2010 and submitted

ryanobjc
old-hbase
HBASE-2997
hbase
HBASE-2997 performance improvements


stack
  1. 
      
  2. Should this be volatile?
  3. Is the trade of cpu for memory space worth it here?
  4. Volatile or is it possible to read partial long?
  5. 
      
ryanobjc
  1. 
      
  2. key values are only used by 1 thread at a time, so no.
    
    and even if they were shared, we'd just result in the current situation - use more cpu than is theoretically necessary.
  3. it actually is worth it... also key values tend to be short lived, but recopying this array out half a dozen times during a scan is pricy according to the profiler.  6% cpu.
  4. in a 64 bit jvm you cannot read a partial long, the updates are atomic.
    
    this is part of the spec.  also single threaded comment above.
  5. 
      
Loading...