HUE-4866 [fb] Allow opening .sql files in editor

Review Request #9427 - Created Jan. 27, 2017 and updated

Information
Sai Chirravuri
hue
master
HUE-4866
0e7d9f7...
Reviewers
hue
enricoberti, johan, ranade, romain, weixia

commit 0e7d9f7f1ab3d232cfed95bad0141f9a9f4dcfee
Author: krish krish@cloudera.com
Date: Thu Jan 26 18:35:33 2017 -0800

HUE-4866 [fb] Allow opening .sql files in editor

:100644 100644 ff44e17... 12f678c... M apps/filebrowser/src/filebrowser/templates/listdir.mako
:100644 100644 2803801... 5638804... M apps/filebrowser/src/filebrowser/templates/listdir_components.mako
:100644 100644 472ad41... 1dad1fc... M desktop/libs/notebook/src/notebook/static/notebook/js/notebook.ko.js
:100644 100644 01b3451... d8780ac... M desktop/libs/notebook/src/notebook/templates/editor_components.mako
:100644 100644 e2b010d... 54f38ea... M desktop/libs/notebook/src/notebook/views.py


  

Issues

  • 7
  • 0
  • 0
  • 7
Description From Last Updated
data-bind="attr: { 'href': .... } In general avoid css classes for ID, use id=... instead, in general avoid id=..., use ... Johan Åhlén Johan Åhlén
This doesn't belong in isSql Johan Åhlén Johan Åhlén
snippetOptions instead of snippet_options Johan Åhlén Johan Åhlén
snippetParams instead of snippet_params Johan Åhlén Johan Åhlén
$.extend(snippetParams, snippetOptions); Johan Åhlén Johan Åhlén
snippetOptions Johan Åhlén Johan Åhlén
How about keeping only this and adding https://review.cloudera.org/r/9829/ ? e.g. huePubSub.publish('open.editor.query.external', {'statementType': 'file', 'statementPath': '/user/romain/test.sql'}); Romain Rigaux Romain Rigaux
Johan Åhlén

   

data-bind="attr: { 'href': .... }

In general avoid css classes for ID, use id=... instead, in general avoid id=..., use ko bindings instead. :-)

Also, class names in css use dash notation, i.e. open-sql-editor-btn

This doesn't belong in isSql

snippetOptions instead of snippet_options

snippetParams instead of snippet_params

$.extend(snippetParams, snippetOptions);

snippetOptions

Romain Rigaux

I kind of think that we could avoid all the changes in notebook and instead just make it work in Hue 4 with pubsub?

Romain Rigaux

   
apps/filebrowser/src/filebrowser/templates/listdir.mako (Diff revision 1)
 
 
 
 
 
 
 

How about keeping only this and adding https://review.cloudera.org/r/9829/
?

e.g.
huePubSub.publish('open.editor.query.external', {'statementType': 'file', 'statementPath': '/user/romain/test.sql'});

Loading...