HUE2533 [useradmin] Only show information updated when it is true

Review Request #9474 - Created Feb. 3, 2017 and submitted

Information
Adrian Yavorskyy
hue
master
HUE-2533
Reviewers
hue
enricoberti, erickt, jennykim, krish, ranade, romain, weixia
commit 69a6c2f2f889ef2035d93eebfcf33e256d7ec150
Author: Adrian Yavorskyy <ayav@softserveinc.com>
Date:   Fri Feb 3 12:55:39 2017 +0200

    HUE2533 [useradmin] Do not accept blank password. Instead show warning message

:100644 100644 538a5ef... 8e85273... M	apps/useradmin/src/useradmin/views.py

Manual on Chrome

Issues

  • 6
  • 3
  • 0
  • 9
Description From Last Updated
We should do the check only when we are doing a password change. Also the check should happen before the ... Romain Rigaux Romain Rigaux
One clean way would be to somehow reuse https://github.com/cloudera/hue/blob/master/apps/useradmin/src/useradmin/password_policy.py or do the check here. Romain Rigaux Romain Rigaux
One clean way would be to somehow reuse https://github.com/cloudera/hue/blob/master/apps/useradmin/src/useradmin/password_policy.py or do the check here. Romain Rigaux Romain Rigaux
Could we keep this true? (in 99% we want to create the home of the users) Romain Rigaux Romain Rigaux
Why would we need this one? Is it because we only offer it for the current user? https://github.com/cloudera/hue/blob/master/apps/useradmin/src/useradmin/templates/edit_user.mako#L80 Romain Rigaux Romain Rigaux
Is there a way to just have: if updated: request.info(_('User information updated')) here and move upt the logic into 'updated' ... Romain Rigaux Romain Rigaux
Adrian Yavorskyy
Adrian Yavorskyy
Romain Rigaux
Adrian Yavorskyy
Romain Rigaux
Adrian Yavorskyy
Romain Rigaux
Adrian Yavorskyy
Romain Rigaux
Adrian Yavorskyy
Romain Rigaux
Adrian Yavorskyy
Adrian Yavorskyy
Romain Rigaux
Adrian Yavorskyy
Romain Rigaux
Adrian Yavorskyy
Romain Rigaux
Romain Rigaux
Adrian Yavorskyy
Romain Rigaux
Adrian Yavorskyy
Review request changed

Status: Closed (submitted)

Loading...