HUE-2214 [fb] Display and set replication

Review Request #9487 - Created Feb. 7, 2017 and submitted

Adrian Yavorskyy
hue
master
hue
enricoberti, erickt, ranade, romain, weixia
commit 64848d1f78cd117bbe14be794317930d2d7adb83
Author: Adrian Yavorskyy <ayav@softserveinc.com>
Date:   Tue Feb 7 16:53:36 2017 +0200

    HUE-2214 [fb]  Display and set replication
    
    Added displaying of a replication factor in file/folder summary
    Implemented setting of a replication factor for files

:100644 100644 1c24f57... b24ef0d... M	apps/filebrowser/src/filebrowser/forms.py
:100644 100644 ff44e17... b80cb56... M	apps/filebrowser/src/filebrowser/templates/listdir.mako
:100644 100644 2803801... 057b6e2... M	apps/filebrowser/src/filebrowser/templates/listdir_components.mako
:100644 100644 59cb825... e70b325... M	apps/filebrowser/src/filebrowser/urls.py
:100644 100644 3603693... 527a130... M	apps/filebrowser/src/filebrowser/views.py
:100644 100644 e45095f... cb3e1df... M	desktop/libs/hadoop/src/hadoop/fs/webhdfs.py

Manually on Chrome

  • 0
  • 0
  • 10
  • 0
  • 10
Description From Last Updated
  1. This is really good and good call to puth the info in the summary popup!

    Little nits here and there to harmonize a bit.

  2. type="text" --> type="number"

  3. Do we want to highlight the file that had is replication changed?

  4. repicationFactorRequiredAlert has a typo

  5. Could you return the result and instead read the potential PopupException in the view? (def set_replication_factor(request):)

    That way the API stays 100% about HDFS

    1. Updated view. Not sure if I understood you correctly, please review.

  6. 
      
  1. Nice!

    Last nits! Then would you prefer to send a git-patch or a pull request?

  2. Could you add

    && !isS3()

    in the visible: equation

    ?

  3. factor is --> 1 extra space

  4. Extra space before:

    'json',

  5. 
      
  1. Awesome, go for it on the jira! Thanks!

    1. Attached patch to jira ticket ! Thanks for review !

  2. 
      
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Loading...