[HUE-5816] Changing default setting as allowed_hosts=['*']

Review Request #9506 — Created Feb. 9, 2017 and submitted

ranade
hue
master
HUE-5816
hue
enricoberti, jennykim, johan, krish, ranade, romain, subrata, weixia
commit 76c20528624e91cb842f862aeef1e7012a3b3eaa
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Thu Feb 9 14:17:50 2017 -0800

    [HUE-5816] Changing default setting as allowed_hosts=['*']
    
    Testing done:
    This way user can still be able to provide declarative allowed_hosts=['settings'] And if not provided it will default to allowed_hosts=["*"] setting.

:100644 100644 0faead4... 994a880... M	desktop/conf.dist/hue.ini
:100644 100644 9227c5b... a0262fa... M	desktop/conf/pseudo-distributed.ini.tmpl
:100644 100644 0b3ddf3... 6937fa5... M	desktop/core/src/desktop/conf.py

This way user can still be able to provide declarative allowed_hosts=['settings'] And if not provided it will default to allowed_hosts=["*"] setting.

  • 0
  • 0
  • 2
  • 1
  • 3
Description From Last Updated
ranade
romain
  1. Could you also update both hue.inis?

  2. desktop/core/src/desktop/conf.py (Diff revision 1)
     
     

    Space after #?

    Add a note on the same line?

    e.g.

    dynamic_default=get_dn, # Currentlt off as pretty disruptive

  3. 
      
ranade
romain
  1. Just remove ' # One can restrict as "host.domain1,host2.domain1"'?

  2. desktop/conf.dist/hue.ini (Diff revision 2)
     
     

    Do we actually need the '# One can restrict as "host.domain1,host2.domain1"' cooment?

  3. Could you move ' # One can restrict as "host.domain1,host2.domain1"' up one line?

    Usually we want people to just uncomment the ##

    If we keep the # One can restrict as "host.domain1,host2.domain1" on the same line, it will break it

    1. not needed to explain because line above explains in detail.

  4. 
      
ranade
Review request changed

Status: Closed (submitted)

Loading...