HUE-5851 [fb] Support the new S3 regions

Review Request #9554 - Created Feb. 16, 2017 and submitted

Enrico Berti
hue
master
hue
jennykim, johan, krish, ranade, romain, weixia
commit 80e9ea594009497dbce81e288fc95a4bd8062f1d
Author: Enrico Berti <hello@enricoberti.com>
Date:   Thu Feb 16 18:15:09 2017 +0100

    HUE-5851 [fb] Support the new S3 regions

:100644 100644 f8b1979... 6703958... M	desktop/core/ext-py/boto-2.42.0/boto/s3/connection.py
:100644 100644 27088a1... e1f25f9... M	desktop/libs/aws/src/aws/s3/s3fs.py
Manual on Chrome
  • 1
  • 0
  • 0
  • 0
  • 1
Description From Last Updated
Instead move this one to https://github.com/cloudera/hue/blob/master/desktop/core/ext-py/boto-2.42.0/boto/s3/connection.py#L138 ? That way when we rebase another day, we will get the new regions ... Romain Rigaux
  1. Ship It!
  2. 
      
  1. 
      
  2. desktop/libs/aws/src/aws/s3/s3fs.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Instead move this one to https://github.com/cloudera/hue/blob/master/desktop/core/ext-py/boto-2.42.0/boto/s3/connection.py#L138 ?

    That way when we rebase another day, we will get the new regions for free

    1. But if we upgrade boto we lose them?

    2. You don't want to fork boto into your code (if we upgrade boto, we might get even more regions but would have to manually change then in s3fs.py and there is not way to see/remember that we hardcoded them there).

      If we upgrade boto, we just diff our past modifications and reapply them, e.g:
      https://github.com/cloudera/hue/commits/master/desktop/core/ext-py/boto-2.42.0

  3. 
      
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Loading...