HUE-3955 [editor] Saving a query should update its description in the saved query list

Review Request #9556 - Created Feb. 16, 2017 and discarded

Adrian Yavorskyy
hue
master
hue
enricoberti, erickt, johan, romain
commit 3effa5945a3d50740c17360256454bb81daec7e9
Author: Adrian Yavorskyy <adrian.yavorski@gmail.com>
Date:   Thu Feb 16 16:22:43 2017 +0200

    HUE-3955 [editor] Saving a query should update its description in the saved query list

:100644 100644 7b9841d... 81a5437... M	desktop/libs/notebook/src/notebook/static/notebook/js/notebook.ko.js

Manual in Chrome

  1. We should probably change the list into Knockout observables and just update their properties instead.

    1. You mean list containing a queries ?

    2. I was thinking more like this: https://review.cloudera.org/r/9564/diff/1#index_header

    3. Understood!
      Have one question: will it work if we are saving a query using "save as"?(https://issues.cloudera.org/browse/HUE-3936). I think we still need to check whether we are saving a new query or resaving the existing one.

    4. Yep, that's still there: https://github.com/cloudera/hue/commit/143327fd75ab73e98452bc9e6d9fc82c29acb153#diff-475ae1aa2a39b635f48e04293ef921edR1930

    5. Got it! Thanks !

  2. 
      
Review request changed

Status: Discarded

Change Summary:

Already closed

Loading...