HUE-5858 [assist] Supporting file open from git browser in assist

Review Request #9562 - Created Feb. 16, 2017 and submitted

Sai Chirravuri
hue
master
HUE-5858
497fdc0...
hue
enricoberti, jennykim, johan, ranade, romain, weixia

commit 980e52da0392252a8a0e615cd2e41522ede89924
Author: krish krish@cloudera.com
Date: Thu Feb 16 17:43:57 2017 -0800

HUE-5858 [assist] Supporting file open from git browser in assist

:100644 100644 a0be0eb... 0b3ddf3... M desktop/core/src/desktop/conf.py
:100644 100644 9acf1cc... ec5de58... M desktop/core/src/desktop/lib/vcs/apis/github_readonly_api.py
:100644 100644 fec7a1e... 0a5d273... M desktop/core/src/desktop/static/desktop/js/apiHelper.js
:100644 100644 714076c... 27ecc97... M desktop/core/src/desktop/static/desktop/js/assist/assistGitEntry.js
:100644 100644 4499acc... 7e1055c... M desktop/core/src/desktop/static/desktop/js/ko.hue-bindings.js

manual

  • 1
  • 0
  • 2
  • 0
  • 3
Description From Last Updated
Any change we could update the snippet name too? We might want the full path to allow to refresh too? ... Romain Rigaux
  1. Nice!

  2. Do we handle it gracefully in the UI or it breaks something?

    1. We see acouple of console errors and popup exception as expected - https://github.com/cloudera/hue/blob/master/desktop/core/src/desktop/static/desktop/js/apiHelper.js#L281

      Other than that had to fix a bit in if-else here
      ApiHelper.prototype.fetchGitContents.

  3. Does it replace the full content?
    (probably better)

    We can see later if we should reset some of the snippet options.

    1. No as of now. Coz we are doing
      editor.getCursorPosition(), "'" + assistGitEntry.fileContent() + "'"

      It will append to whatever is there in the editor already.

      User can Ctrl+Z anyway so I guess we can just replace.

  4. Any change we could update the snippet name too?

    We might want the full path to allow to refresh too? (in another commit. We also need to decide if github readonly should be a special statementType like file or query, can sync)

    1. Will followup updating snippet name in a different commit after we sync on tuesday.

  5. 
      
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Loading...