HUE-4743 [editor] Precision for time counter for queries should not be more than 2 digits

Review Request #9673 - Created Feb. 28, 2017 and submitted

Adrian Yavorskyy
hue
master
hue
enricoberti, erickt, romain

commit ec3b05cbaa9a054d587aa54316465c1cd2c29638
Author: Adrian Yavorskyy <ayav@softserveinc.com>
Date: Tue Feb 28 14:51:05 2017 +0200

HUE-4743 [editor] Precision for time counter for queries should not be more than 2 digits

:100644 100644 84ccc9b... e7aed01... M desktop/core/src/desktop/static/desktop/js/hue.utils.js

Manual in Chrome

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
  1. Thanks!

  2. For this one you should also update and make sure the tests run, /jasmine.

    1. Johan, could you please share how to run jasmine tests? I was trying something like this : 'tools/jasmine/phantomjs.runner.sh desktop/core/src/desktop/templates/jasmineRunner.html', but it's raising ReferenceError: Can't find variable: jasmineReporters. How can I run these tests?

    2. Hi Adrian, you can run it in your browser for now, http://xxxxxx:8000/jasmine

    3. Hi Enrico, thanks for an answer. I installed and set up jasmine locally, but I knew it should somewhere in HUE :) Thanks for help !

  3. 
      
  1. About Jasmine, to add as a note here? https://github.com/cloudera/hue/blob/master/docs/dev/testing.rst

    1. Done! https://issues.cloudera.org/browse/HUE-5961

    2. Great ! Thanks for help !

  2. 
      
  1. Ship It!
    1. I've attached a patch to a jira ticket.

    2. Pushed, thanks!

  2. 
      
Review request changed

Status: Closed (submitted)

Loading...