HUE-5439 [assist] Show database comment as tooltip in editors and add a link to the Metastore DB page in the information popup

Review Request #9725 - Created March 6, 2017 and updated

Information
Adrian Yavorskyy
hue
master
Reviewers
hue
enricoberti, erickt, johan, romain
commit 6322242a871e32dc7f13945d5e691f949fd0a96e
Author: Adrian Yavorskyy <ayav@softserveinc.com>
Date:   Mon Mar 6 17:40:24 2017 +0200

    HUE-5439 [assist] Show database comment as tooltip in editors and add a link to the Metastore DB page in the information popup

:100644 100644 1dce62b... c843294... M	desktop/core/src/desktop/static/desktop/js/assist/assistDbSource.js
:100644 100644 ee8b614... 7f9d2ed... M	desktop/core/src/desktop/templates/assist.mako
:100644 100644 6729794... 638876d... M	desktop/core/src/desktop/templates/sql_context_popover.mako

Manual in Chrome

Issues

  • 5
  • 0
  • 0
  • 5
Description From Last Updated
No need for deferred here, just put line 215-234 in success callback Johan Åhlén Johan Åhlén
Use the ApiHelper instead Johan Åhlén Johan Åhlén
Comment should already be available in the entries elsewhere, shouldn't be a need to fetch the databases again. Johan Åhlén Johan Åhlén
Change above line to isTable || isDatabase, pass type in pubsub, i.e. just one subscription for open.in.metastore Johan Åhlén Johan Åhlén
Johan, need to add comments to the helper API? Romain Rigaux Romain Rigaux
Johan Åhlén
Romain Rigaux
Johan Åhlén
Adrian Yavorskyy
Review request changed

Change Summary:

Added db comment to a popup. Don't if it's better, please review.

Diff:

Revision 3 (+23 -11)

Show changes

Loading...