HUE-3164 [fb] bzip2 files cannot be viewed properly in HUE file browser

Review Request #9732 — Created March 7, 2017 and submitted

adrianyavorskyy
hue
master
hue
enricoberti, erickt, johan, romain
commit a880ea637864b4356df661d7be651f621ae32090
Author: Adrian Yavorskyy <ayav@softserveinc.com>
Date:   Tue Mar 7 16:11:05 2017 +0200

    HUE-3164 [fb] bzip2 files cannot be viewed properly in HUE file browser

:100644 100644 8e019c3... 7a42273... M	apps/filebrowser/src/filebrowser/templates/display.mako
:100644 100644 9155a7a... 9364970... M	apps/filebrowser/src/filebrowser/views.py


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
enricoberti
  1. Leaving the review to Romain since it's backend

  2. contents[:3], right?

  3. 
      
adrianyavorskyy
romain
  1. Nice one!

    How about adding a little test? e.g. similar to https://github.com/cloudera/hue/blob/master/apps/filebrowser/src/filebrowser/views_test.py#L657 or test_view_gz

    1. Yes, sure! I will add a test and update a review!

  2. 
      
adrianyavorskyy
romain
  1. Ship It!
    1. I've attached a patch to jira !

  2. 
      
adrianyavorskyy
Review request changed

Status: Closed (submitted)

Loading...