HUE-6026 [core] The bar chart Y-axis value shouldn't contain 'm'

Review Request #9762 - Created March 9, 2017 and submitted

Enrico Berti
hue
master
hue
jennykim, johan, krish, ranade, romain, weixia
commit 171f0fc7f8bb6e462a76181f2ca1b479a0ab8016
Author: Enrico Berti <hello@enricoberti.com>
Date:   Thu Mar 9 16:38:07 2017 +0100

    HUE-6026 [core] The bar chart Y-axis value shouldn't contain 'm'

:100644 100644 ba7386f... 848d673... M	desktop/core/src/desktop/static/desktop/js/ko.charts.js

Manual on Chrome

Very large numbers (8+ digits) will get cut off now though

  1. That's would be an even bigger problem though so? (billions are no uncommon)

    1. Exactly, that's fairly bad.
      With old SI-notation:
      - big numbers: https://www.dropbox.com/s/puvirj86rju2097/Screenshot%202017-03-09%2016.59.26.png?dl=0
      - small numbers: https://www.dropbox.com/s/nrrd48au4r2wyhu/Screenshot%202017-03-09%2016.59.47.png?dl=0

      With the new one:
      - big numbers: https://www.dropbox.com/s/t7ooppq505skks0/Screenshot%202017-03-09%2016.58.43.png?dl=0
      - small numbers: https://www.dropbox.com/s/13tc1dft6z4lahf/Screenshot%202017-03-09%2016.57.54.png?dl=0

      Both are not optimal actually, because the SI changes both the axis and the tooltip too...

  2. 
      
Review request changed

Status: Closed (submitted)

Loading...