HUE-5765 [editor] Show correct error line number when statement is not on top

Review Request #9976 - Created March 30, 2017 and updated

Adrian Yavorskyy
hue
master
hue
enricoberti, erickt, romain
commit 87bc063c48125dbe797b9da0385bd89171962ea8
Author: Adrian Yavorskyy <ayav@softserveinc.com>
Date:   Thu Mar 30 12:07:34 2017 +0300

    HUE-5765 [editor] Show correct error line number when statement is not on top

:100644 100644 0a5b92d... c536f27... M	desktop/core/src/desktop/static/desktop/js/ko.hue-bindings.js
:100644 100644 685802a... 066f7a1... M	desktop/libs/notebook/src/notebook/connectors/hiveserver2.py

Manually in Chrome

  1. Does this work if you have let's say 3 queries, you select and highlight the second one with the mouse and execute that one?

    1. I haven't thought about that. Thanks for suggestion.
      I tried and it's not working. I will continue working on it !

  2. 
      
Review request changed

Change Summary:

Added checking whether one query is being run among others(as Enrico described above). Tried to use ternary operator to avoid if statements, but it appeared to be unreadable and not fully working.

Diff:

Revision 2 (+24 -7)

Show changes

Loading...